Animated: Generalize ReactElement Check in AnimatedObject
#46273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The implementation of `AnimatedObject` should recurse through its structure and consistently treat `ReactElement` objects as opaque. It wasn't consistent. This makes it consistent. Changelog: [General][Fixed] - Fixed undefined behavior in certain scenarios when `ReactElement` objects are supplied to Animated components Differential Revision: D62012006
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62012006 |
|
This pull request has been merged in 56937d6. |
|
This pull request was successfully merged by @yungsters in 56937d6 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The implementation of
AnimatedObjectshould recurse through its structure and consistently treatReactElementobjects as opaque.It wasn't consistent. This makes it consistent.
Changelog:
[General][Fixed] - Fixed undefined behavior in certain scenarios when
ReactElementobjects are supplied to Animated componentsDifferential Revision: D62012006